-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add post-installation redirect based on admin account status #34493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't speak on frontend design, but otherwise this looks good to me.
Was iffy about the HasUsers()
calls ignoring DB errors, but after further reading it seems the worst that can happen is:
- User accesses sign up page (or completes the install config if they're on the install page)
- A DB error occurs
- Server sends sign up page + the
sign_up_tip
message to the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
And also please review admin related bug fix: Fix last admin check when syncing users #34649 |
This PR adds a feature to direct users to appropriate pages after system installation: