Refactor commit reader #34542
Merged
Refactor commit reader #34542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-commit-reader
branch
from
1d6f91c to
1f43769
Compare
|
I just want to highlight that Git solves this by 'cutting' out the signature, leaving only the parts of the commits that should be signed, independently of possibly unknown header fields. https://github.com/git/git/blob/cb96e1697ad6e54d11fc920c95f82977f8e438f8/commit.c#L1170-L1213 This also makes the approach more resilient against unconventionally formatted commits, I believe. |
That's what I do in this PR |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
May 27, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 27, 2025
wxiaoguang
added a commit
that referenced
this pull request
May 27, 2025
Backport #34542 by wxiaoguang Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.