Skip to content

Feature: add Namer-driven column name lookup in schema field retrieval #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+13 −0
Open

Feature: add Namer-driven column name lookup in schema field retrieval #7619

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be120a5
feat: add namer-driven column name lookup in schema field retrieval
cmmoran Oct 18, 2025
1317fee
fix: safely check for underlying type == nil
cmmoran Oct 18, 2025
af318c0
fix: reverted "safe" check
cmmoran Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions schema/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,19 @@ func (schema *Schema) LookUpField(name string) *Field {
if field, ok := schema.FieldsByName[name]; ok {
return field
}

// Lookup field using namer-driven ColumnName
if schema.namer == nil {
return nil
}
namerColumnName := schema.namer.ColumnName(schema.Table, name)
if len(namerColumnName) == 0 || namerColumnName == name {
return nil
}
if field, ok := schema.FieldsByDBName[namerColumnName]; ok {
return field
}

return nil
}

Expand Down
Loading