Improve clickhouse table creation#154
Conversation
854d70e to
c2d650a
Compare
Hipska
left a comment
There was a problem hiding this comment.
Looks good overall, but I'm only wondering what exactly you mean with "will be almost always 0"?
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
|
E.g., when we have a column with values |
|
I still haven't tested the performance of this changes. Is a bit stuck on go-graphite/graphite-clickhouse-tldr#6 to have the tags and all other stuff in the DB |
|
Thanks to inform this, I was going to apply this to PROD, but will wait. It is doing fine on a small DEV server: |
Hipska
left a comment
There was a problem hiding this comment.
Maybe use TTL based on Date column to align with graphite data table? That way it also won't cause issues when Version isn't representing a timestamp anymore..
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
|
|
||
| You can create Replicated tables. See [ClickHouse documentation](https://clickhouse.tech/docs/en/engines/table-engines/mergetree-family/replication/) | ||
|
|
||
| 3. One should always use [graphite-ch-optimizer](https://github.com/innogames/graphite-ch-optimizer) together with carbon-clickhouse and [graphite-clickhouse](https://github.com/go-graphite/graphite-clickhouse). Without it, the rules from `graphite-rollup` configuration aren't applied automatically. |
There was a problem hiding this comment.
| 3. One should always use [graphite-ch-optimizer](https://github.com/innogames/graphite-ch-optimizer) together with carbon-clickhouse and [graphite-clickhouse](https://github.com/go-graphite/graphite-clickhouse). Without it, the rules from `graphite-rollup` configuration aren't applied automatically. | |
| 3. One should always use [graphite-ch-optimizer](https://github.com/innogames/graphite-ch-optimizer) together with carbon-clickhouse and [graphite-clickhouse](https://github.com/go-graphite/graphite-clickhouse). Without it, the rules from `graphite_rollup` configuration aren't applied automatically. |
I need as well to test all the tables for performance before merging it