Add Client.Clone function

[fabiante]

This adds a crude cloning function. It can be used to have a main client with default values and then create copies from that, which must use custom values.

The added function is rather crude and may introduce the potential that, when adding a new Client field, we forget to add it to Clone.

Thus, we should discuss if this is the right way to go. Using code generation or relflection might be a more maintainable solution.

Merging this PR would close #773

[jeevatkm]

@fabiante Thanks for creating a draft. I have read the issue thread #773.

Can you please update the PR as follows?

Add a new method

// Clone returns a clone of the original client.
//  <add further doc info here>
//
// Since v2.12.0
func (c *Client) Clone() *Client {
	// dereference the pointer and copy the value
	cc := *c
	return &cc
}

Change these field definitions to a pointer type.

• resty/client.go

  Line 145 in 97187c4

  udBeforeRequestLock sync.RWMutex

• resty/client.go

  Line 149 in 97187c4

  afterResponseLock sync.RWMutex

udBeforeRequestLock *sync.RWMutex
.
.
.
afterResponseLock   *sync.RWMutex

Finally, initialize the fields while creating a new client

resty/client.go

Line 1343 in 97187c4

func createClient(hc *http.Client) *Client {

[jeevatkm]

Thanks, @fabiante, for handling PR comments.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (0ac42a2) to head (2c5a4a7).

Additional details and impacted files

@@            Coverage Diff             @@
##               v2     #774      +/-   ##
==========================================
+ Coverage   96.46%   96.48%   +0.01%     
==========================================
  Files          12       12              
  Lines        1643     1650       +7     
==========================================
+ Hits         1585     1592       +7     
  Misses         37       37              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.