Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] use AddEventListener check instead of OnMessage check #989

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
+4 −3
Open

[refactor] use AddEventListener check instead of OnMessage check #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d8376e
[refactor] use AddEventListener check instead of OnMessage check
Mar 21, 2025
87dff8f
[chore] correct TestEventSourceCoverage function
Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,9 @@ func (es *EventSource) Get() error {
if isStringEmpty(es.url) {
return fmt.Errorf("resty:sse: event source URL is required")
}
if _, found := es.onEvent[defaultEventName]; !found {
return fmt.Errorf("resty:sse: OnMessage function is required")

if len(es.onEvent) == 0 {
return fmt.Errorf("resty:sse: At least one OnMessage/AddEventListener func is required")
}

// reset to begin
Expand Down
2 changes: 1 addition & 1 deletion sse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ func TestEventSourceCoverage(t *testing.T) {

es.SetURL("https://sse.dev/test")
err2 := es.Get()
assertEqual(t, "resty:sse: OnMessage function is required", err2.Error())
assertEqual(t, "resty:sse: At least one OnMessage/AddEventListener func is required", err2.Error())

es.OnMessage(func(a any) {}, nil)
es.SetURL("//res%20ty.dev")
Expand Down