Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nil credentials before clone #990

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

gtwn
Copy link
Contributor

@gtwn gtwn commented Mar 21, 2025

can not clone parent client if not set credentials

@gtwn gtwn changed the base branch from main to v3 March 21, 2025 06:20
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (e158f04) to head (f00069c).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3     #990   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          18       18           
  Lines        3882     3885    +3     
=======================================
+ Hits         3875     3878    +3     
  Misses          5        5           
  Partials        2        2           
Flag Coverage Δ
unittests 99.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeevatkm jeevatkm merged commit 575bf38 into go-resty:v3 Mar 22, 2025
6 checks passed
@jeevatkm
Copy link
Member

@gtwn Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants