Skip to content

Fix SAP HANA mvt provider. Upgrade driver version and dependencies#1086

Draft
remi-sap wants to merge 1 commit into
go-spatial:masterfrom
remi-sap:fix/hana-mvt-provider-upgrade
Draft

Fix SAP HANA mvt provider. Upgrade driver version and dependencies#1086
remi-sap wants to merge 1 commit into
go-spatial:masterfrom
remi-sap:fix/hana-mvt-provider-upgrade

Conversation

@remi-sap

Copy link
Copy Markdown

Hello,
I had an issue connecting tegola to SAP HANA Cloud as an MVT provider.
I noticed the driver for SAP HANA was old so I refreshed it, hence the hundreds of changed files under vendor/

@remi-sap remi-sap requested review from ARolek and gdey as code owners March 25, 2026 14:01

@iwpnd iwpnd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ARolek

ARolek commented Mar 25, 2026

Copy link
Copy Markdown
Member

@mrylov you were the main contributor to this part of the codebase. Are you still available for a review?

@ARolek

ARolek commented Mar 25, 2026

Copy link
Copy Markdown
Member

@remi-sap do you work with @mrylov by chance (noticed "sap" in your handle)?

Also, can you check the CI. Looks like a test is failing. Once that's fixed I can accept this PR.

@remi-sap

Copy link
Copy Markdown
Author

Hi @ARolek , yes I work with @mrylov who found the root cause of the issue. I'll review the failure.

@ARolek

ARolek commented Mar 25, 2026

Copy link
Copy Markdown
Member

@remi-sap great!

@remi-sap

Copy link
Copy Markdown
Author

Besides vulnerabilities, tests for HANA as a provider are failing.
I'm switching this PR to draft to work on that.

@remi-sap remi-sap marked this pull request as draft March 25, 2026 21:03
@ARolek

ARolek commented Mar 25, 2026

Copy link
Copy Markdown
Member

Besides vulnerabilities,

I will get this fixed up in master.

@mrylov

mrylov commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Hi @ARolek, Hi @remi-sap,

I've prepared a working fix in my forked repository, see mrylov@f462197.

@remi-sap, could you please adjust your change accordingly?

Thank you and kind regards

@ARolek

ARolek commented Mar 29, 2026

Copy link
Copy Markdown
Member

The govulncheck issue is resolved in master now. Please reabase this branch when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants