Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: add tandoor #13560

Merged

Conversation

chwshka
Copy link
Contributor

@chwshka chwshka commented Mar 18, 2025

Details

Adds documentation on integrating Tandoor recipe manager with authentik.

This would close #6609


Checklist

Inapplicable - [ ] Local tests pass (`ak test authentik/`) - [ ] The code has been formatted (`make lint-fix`)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
If applicable
  • The documentation has been updated
  • The documentation has been formatted (make website)

@chwshka chwshka requested a review from a team as a code owner March 18, 2025 09:13
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ff7472d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67dbd9d757226f000811540e

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit ff7472d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67dbd9d7eb3e2d00083d7b30
😎 Deploy Preview https://deploy-preview-13560--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chwshka Thank you for opening this PR, it is greatly appreciated. Here are a few suggestions to get your review going. Please do LMK if you have any questions concerning this review!

@chwshka
Copy link
Contributor Author

chwshka commented Mar 18, 2025

@dominic-r I think I've matched the document with the new template. Let me know if you spot anything else.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Here are a few more related to that new section. Otherwise, this looks pretty good!

@dominic-r
Copy link
Contributor

@chwshka Hi, I notice the documentation build is failing. Before merging, these errors would need to be resolved. Can you take a look at this when you have a second? Thanks

@dominic-r
Copy link
Contributor

By the looks of it, the error is in the provider configuration, KBD isn't meant for multi line code blocks, you should use ``` instead

@chwshka
Copy link
Contributor Author

chwshka commented Mar 19, 2025

By the looks of it, the error is in the provider configuration, KBD isn't meant for multi line code blocks, you should use ``` instead

That's fixed. The codeblock is now using ```. The environment variables codeblock includes <em></em> sections. I assume this is ok?

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (ad27f26) to head (ff7472d).
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13560      +/-   ##
==========================================
+ Coverage   92.73%   92.76%   +0.02%     
==========================================
  Files         794      794              
  Lines       40425    40493      +68     
==========================================
+ Hits        37487    37562      +75     
+ Misses       2938     2931       -7     
Flag Coverage Δ
e2e 47.96% <ø> (-0.02%) ⬇️
integration 24.28% <ø> (-0.03%) ⬇️
unit 90.52% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tanberry
Copy link
Contributor

Hi @chwshka thanks for this PR. Thanks also for linking to PR# #6609. Was it not possible to add to that PR, and co-author it with the original contributor? Maybe not, perhaps the technical details had changed too much, but I wanted to ask. We can go ahead and merge yours, and if OK with you, in the closing comments I'd like to acknowledge the work the original contributor(s) did?

@chwshka
Copy link
Contributor Author

chwshka commented Mar 20, 2025

Hi @chwshka thanks for this PR. Thanks also for linking to PR# #6609. Was it not possible to add to that PR, and co-author it with the original contributor? Maybe not, perhaps the technical details had changed too much, but I wanted to ask. We can go ahead and merge yours, and if OK with you, in the closing comments I'd like to acknowledge the work the original contributor(s) did?

That probably would have been better. I'll do that next time. I'd be happy to have the author of #6609 acknowledged.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chwshka for this contribution, and thanks also to @fyksen and several others for their work on the original #6609 PR. It's great to have Tandoor integration now documented!

@tanberry tanberry merged commit 59d20e3 into goauthentik:main Mar 24, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants