-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: add tandoor #13560
website/integrations: add tandoor #13560
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chwshka Thank you for opening this PR, it is greatly appreciated. Here are a few suggestions to get your review going. Please do LMK if you have any questions concerning this review!
Co-authored-by: Dominic R <[email protected]> Signed-off-by: Dewi Roberts <[email protected]>
Co-authored-by: Dominic R <[email protected]> Signed-off-by: Dewi Roberts <[email protected]>
Co-authored-by: Dominic R <[email protected]> Signed-off-by: Dewi Roberts <[email protected]>
Co-authored-by: Dominic R <[email protected]> Signed-off-by: Dewi Roberts <[email protected]>
@dominic-r I think I've matched the document with the new template. Let me know if you spot anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Here are a few more related to that new section. Otherwise, this looks pretty good!
Co-authored-by: Dominic R <[email protected]> Signed-off-by: Dewi Roberts <[email protected]>
@chwshka Hi, I notice the documentation build is failing. Before merging, these errors would need to be resolved. Can you take a look at this when you have a second? Thanks |
By the looks of it, the error is in the provider configuration, KBD isn't meant for multi line code blocks, you should use ``` instead |
That's fixed. The codeblock is now using ```. The environment variables codeblock includes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13560 +/- ##
==========================================
+ Coverage 92.73% 92.76% +0.02%
==========================================
Files 794 794
Lines 40425 40493 +68
==========================================
+ Hits 37487 37562 +75
+ Misses 2938 2931 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @chwshka thanks for this PR. Thanks also for linking to PR# #6609. Was it not possible to add to that PR, and co-author it with the original contributor? Maybe not, perhaps the technical details had changed too much, but I wanted to ask. We can go ahead and merge yours, and if OK with you, in the closing comments I'd like to acknowledge the work the original contributor(s) did? |
That probably would have been better. I'll do that next time. I'd be happy to have the author of #6609 acknowledged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
Adds documentation on integrating Tandoor recipe manager with authentik.
This would close #6609
Checklist
Inapplicable
- [ ] Local tests pass (`ak test authentik/`) - [ ] The code has been formatted (`make lint-fix`)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)make website
)