-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Fix error when viewing used_by for built-in source #13588
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13588 +/- ##
==========================================
- Coverage 92.76% 92.74% -0.03%
==========================================
Files 794 794
Lines 40577 40589 +12
==========================================
Hits 37643 37643
- Misses 2934 2946 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
what? I didn't change docs at all. Will ignore |
The error you're seeing is probably a symptom of a missing UsedByMixin on a serializer. Do you know which model this is failing on? |
Oh my @rissson Completly forgot to answer this. I'll push a commit which should fix this issue |
Verification: cURL (GET) http://localhost:9000/api/v3/sources/all/authentik-built-in/used_by/ : |
f083950
to
e5eb08d
Compare
Could we add a test for this as well? I can quickly do it if you want me to |
Sure, thanks |
What
This PR fixes an error that occurs when trying to view the /used_by/ API endpoint for the built-in source. Previously, accessing this endpoint would raise a NotImplementedError because the built-in source doesn't properly implement the required abstract methods.
How
Testing:
Confirmed the /api/v3/sources/all/authentik-built-in/used_by/ endpoint now returns a proper response instead of a 500 (I think) error
Closes #13587<!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://docs.goauthentik.io/docs/developer-docs/#how-can-i-contribute
-->
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)