-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: ensure wizard modal closes on first cancel click #13636
web: ensure wizard modal closes on first cancel click #13636
Conversation
The application wizard modal previously required two clicks of the cancel button to close when opened from the User Interface. This was caused by improper event handling where events would propagate up the DOM tree potentially triggering multiple handlers.
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc @kensternberg-authentik I vaguely remember you saying that this was complex to fix (? or no one was going to notice). I got it working, considering what you said, can you please tell me if I overlooked something? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13636 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 794 794
Lines 40508 40508
=======================================
+ Hits 37572 37573 +1
+ Misses 2936 2935 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I thought the problem was that the modal was invoked twice, resulting in two modals that needed to be closed in succession.
The application wizard modal previously required two clicks of the cancel button to close when opened from the User Interface. This was caused by improper event handling where events would propagate up the DOM tree potentially triggering multiple handlers.
qa:
https://github.com/user-attachments/assets/34ea6565-4424-4a8e-9ae0-7f91c0e43f1e
pr:
https://github.com/user-attachments/assets/7fcea70b-e268-424d-ad10-6827b9bc9815
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)