Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: ensure wizard modal closes on first cancel click #13636

Merged

Conversation

dominic-r
Copy link
Contributor

@dominic-r dominic-r commented Mar 22, 2025

The application wizard modal previously required two clicks of the cancel button to close when opened from the User Interface. This was caused by improper event handling where events would propagate up the DOM tree potentially triggering multiple handlers.

qa:
https://github.com/user-attachments/assets/34ea6565-4424-4a8e-9ae0-7f91c0e43f1e

pr:
https://github.com/user-attachments/assets/7fcea70b-e268-424d-ad10-6827b9bc9815

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

The application wizard modal previously required two clicks of the cancel
button to close when opened from the User Interface.
This was caused by improper event handling where events
would propagate up the DOM tree potentially triggering multiple handlers.
@dominic-r dominic-r requested a review from a team as a code owner March 22, 2025 18:33
Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit a1e8e80
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67df0291c13325000803e255

Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit a1e8e80
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67df02915bd1190008d39bb0
😎 Deploy Preview https://deploy-preview-13636--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dominic-r
Copy link
Contributor Author

dominic-r commented Mar 22, 2025

cc @kensternberg-authentik I vaguely remember you saying that this was complex to fix (? or no one was going to notice). I got it working, considering what you said, can you please tell me if I overlooked something?

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (3eccef8) to head (a1e8e80).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13636   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         794      794           
  Lines       40508    40508           
=======================================
+ Hits        37572    37573    +1     
+ Misses       2936     2935    -1     
Flag Coverage Δ
e2e 47.97% <ø> (+<0.01%) ⬆️
integration 24.30% <ø> (ø)
unit 90.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I thought the problem was that the modal was invoked twice, resulting in two modals that needed to be closed in succession.

@BeryJu BeryJu merged commit 27aed4b into goauthentik:main Mar 26, 2025
88 checks passed
@dominic-r dominic-r deleted the sdko/fix-double-click-wizard-userinterf branch March 26, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants