Get test matrix up to date #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.5-preview hasn't had a release since April 2025, and I suspect won't be released https://www.ruby-lang.org/en/downloads/releases/ In any case, having this pre-release version is blocking upgrades to sqlite3: https://github.com/gocardless/statesman/actions/runs/20566094014/job/59064554664?pr=559
Rails main now requires ruby 3.3+
This seems to have been added originally to gemspec in 2013: 0d2d90c Specifying bundler in the Gemfile is unnecessary and not good practice. It is also preventing us from testing on ruby 4.0, as that only supports newer bundler versions.
Tabby
reviewed
Jan 5, 2026
Comment on lines
+34
to
+36
| exclude: | ||
| - ruby-version: "3.2" | ||
| rails-version: "main" |
Contributor
There was a problem hiding this comment.
Presumably this is because of rails 8.1, so we should probably add "8.1" to the matrix explicitly as well
Contributor
Author
There was a problem hiding this comment.
Rails 8.1 doesn't seem to require 3.3+, but it is worth adding 8.1 to the test matrix 👍
This is no longer supported
JoeSouthan
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.5-preview hasn't had a release since April 2025, and I suspect won't be released
https://www.ruby-lang.org/en/downloads/releases/
In any case, having this pre-release version is blocking upgrades to sqlite3: https://github.com/gocardless/statesman/actions/runs/20566094014/job/59064554664?pr=559