Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for shader built-in include files (godotengine/godot#94193) #10703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackerty
Copy link
Contributor

Documents merged feature godotengine/godot#94193 to the end of the compute shader tutorial.

If someone has a better example in mind I'm open to suggestions. I just wanted something short that does not have too much extra code around the include.

@skyace65 skyace65 added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders labels Feb 22, 2025
@skyace65 skyace65 added this to the 4.4 milestone Feb 22, 2025
@skyace65 skyace65 requested review from BastiaanOlij and tetrapod00 and removed request for BastiaanOlij and tetrapod00 February 22, 2025 12:56
@Jackerty Jackerty force-pushed the doc-for-94193 branch 3 times, most recently from eecbe70 to 93fb248 Compare February 25, 2025 19:45
@skyace65
Copy link
Contributor

Are you running your non-code text for this PR through a translator?

@Jackerty
Copy link
Contributor Author

Jackerty commented Feb 26, 2025

I do run them through (freemium) Grammarly...

)

Documents merged feature godotengine/godot#94193 to the end of the compute shader tutorial.

If someone has a better example in mind I'm open to suggestions. I just wanted something short that isn't too much extra code around the include.
@Jackerty
Copy link
Contributor Author

To be clear, can I fix that CI error or should I wait?

@fire
Copy link
Member

fire commented Feb 26, 2025

Please fix CI errors as soon as you can!

@Jackerty
Copy link
Contributor Author

Jackerty commented Feb 26, 2025

I don't think that CI error is caused by this PR

@Jackerty
Copy link
Contributor Author

For future reference

Run /home/runner/work/_actions/lycheeverse/lychee-action/v2/entrypoint.sh
   [WARN ] Error creating request: InvalidBaseJoin("_static/")
   [WARN ] Error creating request: InvalidBaseJoin("res://someresource.res::1")
Error:  https://webd97.de/post/gitlab-pages-compression/ | Network error: error sending request for url (https://webd97.de/post/gitlab-pages-compression/) Maybe a certificate error?
# Summary

| Status        | Count |
|---------------|-------|
| 🔍 Total      | 1633  |
| ✅ Successful | 893   |
| ⏳ Timeouts   | 0     |
| 🔀 Redirected | 0     |
| 👻 Excluded   | 739   |
| ❓ Unknown    | 0     |
| 🚫 Errors     | 1     |

## Errors per input

### Errors in tutorials/export/exporting_for_web.rst

Error: R] [https://webd97.de/post/gitlab-pages-compression/](https://webd97.de/post/gitlab-pages-compression/) | Network error: error sending request for url (https://webd97.de/post/gitlab-pages-compression/) Maybe a certificate error?

Error: Process completed with exit code 2.

@Jackerty
Copy link
Contributor Author

There is a broken link in exporting_for_web.rst. Making an issue.

@Jackerty
Copy link
Contributor Author

What I found -> #10717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants