Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Odin binding to community GDExtension binding list #10724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dresswithpockets
Copy link

Adds a link to the odin-godot GDExtension binding to the community-maintained binding list.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 28, 2025
@skyace65 skyace65 added the foundation Godot Foundation approval required (legal, thirdparty links etc.) label Mar 2, 2025
@tetrapod00 tetrapod00 requested a review from a team March 4, 2025 22:52
@dsnopek
Copy link
Contributor

dsnopek commented Mar 5, 2025

I presume review from the GDExtension team was requested to see if the binding was "well-developed enough" like the docs say :-)

Unfortunately, it's really hard to review bindings for languages that I don't know, especially if the binding is written in the language itself, which appears to be the case here.

I usually end up looking for community indicators, like the number of GitHub stars (61), issues (1 closed), PRs (3 closed). Going by those indicators, this project appears to be somewhat less active and popular than other bindings we have listed. But Odin is also a less popular programming language than the others too?

It's super hard to say. Unless there's someone in the community we know and trust who knows Odin and can review better, I would probably err on the side of including it (there's no issues complaining it doesn't work at all :-)), and we can always remove later if there's problems?

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was looking for a general assessment. Thanks for taking a look. This one did seem okay to me on the metrics I can see, within the realm of recently approved Nim on stars (~60), but with less overall history and contributors than the Nim bindings.

In general I also would err on the side of including bindings in our docs and removing them later if they are no longer maintained. So I think this one is good enough to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement foundation Godot Foundation approval required (legal, thirdparty links etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants