Document support for 2D per-instance uniforms in Shading language #10749
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Calinou
commented
Mar 6, 2025
Calinou
commented
- See tutorials/shaders/shader_reference/shading_language godot-docs-user-notes#314 (comment).
Calinou
added
enhancement
area:manual
tetrapod00
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Supersedes #10737 if merged.
This section also mentions GeometryInstance3D specifically a few places. Those should likely be amended to also mention CanvasItem too.
Comment on lines
+1061
to
+1063
| Since Godot 4.4, per-instance uniforms are available in ``canvas_item`` (2D) | ||
| and ``spatial`` (3D) shaders. Prior to Godot 4.4, per-instance uniforms are | ||
| only available in ``spatial`` shaders. |
There was a problem hiding this comment.
Suggested change
| Since Godot 4.4, per-instance uniforms are available in ``canvas_item`` (2D) | |
| and ``spatial`` (3D) shaders. Prior to Godot 4.4, per-instance uniforms are | |
| only available in ``spatial`` shaders. | |
| Since Godot 4.4, per-instance uniforms are available in both ``canvas_item`` (2D) | |
| and ``spatial`` (3D) shaders. |
I don't think we should explicitly mention older versions like this?
Or just drop the first version if the wording is ambiguous:
Suggested change
| Since Godot 4.4, per-instance uniforms are available in ``canvas_item`` (2D) | |
| and ``spatial`` (3D) shaders. Prior to Godot 4.4, per-instance uniforms are | |
| only available in ``spatial`` shaders. | |
| Per-instance uniforms are available in both ``canvas_item`` (2D) and ``spatial`` (3D) shaders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.