Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to play the mob animation #10752

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

utsav132
Copy link
Contributor

@utsav132 utsav132 commented Mar 6, 2025

Added script to play the mob animation, along with its explanation in the docs.

In 'Your first 2D game' in the Getting Started part, the docs tell you how to randomly select mob animation (in creating the enemy), but don't show you how to play it. The '$AnimatedSprite2D.play()' part was missing the the script. This, along with it's docs, has been added in this pull request.

utsav132 added 2 commits March 7, 2025 01:27
Added script to play the mob animation, along with its explanation in the docs.
@skyace65
Copy link
Contributor

skyace65 commented Mar 6, 2025

Since this PR changes demo project code please open a corresponding PR in the demo projects repository. https://github.com/godotengine/godot-demo-projects

EDIT: It looks like play is already in the demo repository script, though it's at the beginning of the function which is odd. Still, these need to be in sync

@skyace65 skyace65 added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation needs work Needs additional work by the original author, someone else or in another repo. labels Mar 6, 2025
@utsav132
Copy link
Contributor Author

utsav132 commented Mar 7, 2025

I have corrected the code in the godot-demo-projects repository. I added the line to play animation at the end, which is in sync with this PR.

It's in the following PR:
Added line to play animation at the end. #1175
godotengine/godot-demo-projects#1175

@skyace65 skyace65 added Linked Demo PR Doc PRs that are tied to a demo repository PR and removed needs work Needs additional work by the original author, someone else or in another repo. labels Mar 7, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 0b174c6 into godotengine:master Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement Linked Demo PR Doc PRs that are tied to a demo repository PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants