Rename Control::_size_changed to Control::_rect_changed #106675
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a strictly internal method, so I'm not sure the noise in the git history by renaming this is reasonable |
|
Names of internal methods help contributors using them correctly, so it's not like it's completely pointless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Control::_size_changed method may not be properly named, as it is called not only when size is changed, but also when position is changed. It also updates the size and position caches. Renaming it to _rect_changed might better reflect what it does.
This method is not bound in the _bind_method and the accessibility is private, so renaming it won't break compatibility