Skip to content

Conversation

@beicause
Copy link
Contributor

Implement the suggestion of godotengine/godot-proposals#10738 (comment). Disabling visual_shader makes Linux and Android template_release smaller by ~1.8 MB

@beicause beicause requested review from a team as code owners July 26, 2025 03:22
@beicause beicause changed the title Move VisualShader to its own folder, allow to build export template without it Move VisualShader to its own folder, allow building export template without it Jul 26, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Jul 28, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Jul 30, 2025

Isn't it possible to move VisualShader to its own module? 🤔

@beicause
Copy link
Contributor Author

It is possible, but ideally the editor should not depend on modules, more work is needed to refactor the shader editor and add an abstraction layer. If #64596 gets salvaged I’d be happy to close this PR.

@KoBeWi
Copy link
Member

KoBeWi commented Jul 31, 2025

Doesn't look like there is an easy way to remove VisualShader dependencies from the editor and refactoring isn't really worth it if we don't plan to support more shader types.

EDIT:
Ok, now I see that this only handles export templates. This makes it simpler, and is why the module would be less feasible.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs buildsystem review, other changes look fine.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jul 31, 2025
@aaronfranke
Copy link
Member

I opened PRs #109998 and #109999 to clean up the shader editor code, and rebased PR #64596.

@aaronfranke
Copy link
Member

PR #112100 separates out the language-specific code, and is the last cleanup before PR #64596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants