Skip to content

Update documentation pages when switching themes #112141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Update documentation pages when switching themes #112141

merged 1 commit into from
Oct 29, 2025

Conversation

@YeldhamDev
Copy link
Member

Otherwise, already opened pages will look incorrect:

image

@YeldhamDev YeldhamDev added this to the 4.6 milestone Oct 29, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner October 29, 2025 01:40
@YeldhamDev YeldhamDev added bug topic:editor documentation cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 29, 2025
Mickeon
Mickeon approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight caught when testing the new minimal theme I am sure.
A similar line also exists for NOTIFICATION_TRANSLATION_CHANGED, so nothing new here.

@Repiteo Repiteo merged commit e5e2c06 into godotengine:master Oct 29, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 29, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the whats_up_doc branch October 29, 2025 19:03
@Mickeon Mickeon mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Repiteo Repiteo Repiteo approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees

No one assigned

Labels

bug cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release documentation topic:editor

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

3 participants

@YeldhamDev @Repiteo @Mickeon