Fix wrong pointer in compatibility_test_init null check#120677
Open
BrianLegge wants to merge 1 commit into
Open
Fix wrong pointer in compatibility_test_init null check#120677BrianLegge wants to merge 1 commit into
BrianLegge wants to merge 1 commit into
Conversation
compat_checker.c contains a series of proc-address lookups, each of which retrieves and validates a function pointer. The lookup for string_name_new_with_latin1_chars checks the wrong pointer; it tests the previously assigned classdb_get_method_bind rather than string_name_new_with_latin1_chars. If string_name_new_with_latin1_chars ever failed to resolve, init would still return success and the extension would later dereference a NULL pointer in startup_func. This would crash instead of printing the intended "Failed to load interface method" error. This fix aligns the check with the five sibling checks in the same function, each of which validates its own just-assigned pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compat_checker.c contains a series of proc-address lookups, each of which retrieves and validates a function pointer. The lookup for string_name_new_with_latin1_chars checks the wrong pointer; it tests the previously assigned classdb_get_method_bind rather than string_name_new_with_latin1_chars.
If string_name_new_with_latin1_chars ever failed to resolve, init would still return success and the extension would later dereference a null pointer in startup_func. This would crash instead of printing the intended "Failed to load interface method" error. This fix aligns the check with the five sibling checks in the same function, each of which validates its own just-assigned pointer.