Fix Tree node mouse dragging regression on touchscreens#120728
Open
syntaxerror247 wants to merge 1 commit into
Open
Fix Tree node mouse dragging regression on touchscreens#120728syntaxerror247 wants to merge 1 commit into
syntaxerror247 wants to merge 1 commit into
Conversation
syntaxerror247
added
bug
topic:input
regression
cherrypick:4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing logic allowed
drag-and-dropeven whendrag_touchingwas true, for mouse input. Butdrag_touchingandTreeItemdrag-and-drop are conflicting with each other, and prevents drag scrolling from being released properly.This PR fixes the issue by disabling drag scrolling when using mouse input. Only thing is that first touch after using mouse, will start dragging instead of scolling.