Feat/ergonomics 2.0

bridge/jsb_bridge_helper.h

@@ -35,7 +35,7 @@ namespace jsb
             const v8::Local<v8::Object> enumeration = v8::Object::New(isolate);
             for (const KeyValue<StringName, int64_t>& kv : enum_values)
             {
-                const v8::Local<v8::String> name = impl::Helper::new_string(isolate, kv.key);
+                const v8::Local<v8::String> name = impl::Helper::new_string(isolate, internal::NamingUtil::get_enum_value_name(kv.key));
                 const v8::Local<v8::Value> value = impl::Helper::new_integer(isolate, kv.value);
                 enumeration->Set(context, name, value).Check();
                 // represents the value back to string for convenient uses, such as MyColor[MyColor.White] => 'White'

bridge/jsb_bridge_module_loader.cpp

@@ -305,24 +305,27 @@ namespace jsb
             v8::Local<v8::Object> target = info[0].As<v8::Object>();
             v8::Local<v8::Object> details = info[1].As<v8::Object>();
 
+            jsb_check(target->IsObject());
+            jsb_check(details->IsObject());
+
             Environment* environment = Environment::wrap(isolate);
             v8::Local<v8::Symbol> symbol = jsb_symbol(environment, ClassProperties);
             v8::Local<v8::Array> collection;
-            v8::Local<v8::Value> val_test;
             uint32_t index;
-            if (v8::MaybeLocal<v8::Value> maybe = target->Get(context, symbol); !maybe.ToLocal(&val_test) || val_test->IsUndefined())
+            if (target->HasOwnProperty(context, symbol).ToChecked())
+            {
+                v8::Local<v8::Value> collection_val = target->Get(context, symbol).ToLocalChecked();
+                jsb_check(collection_val->IsArray());
+                collection = collection_val.As<v8::Array>();
+                index = collection->Length();
+            }
+            else
             {
                 index = 0;
                 collection = v8::Array::New(isolate);
                 jsb_quickjs_check(collection->IsArray());
                 target->Set(context, symbol, collection).Check();
             }
-            else
-            {
-                jsb_check(val_test->IsArray());
-                collection = val_test.As<v8::Array>();
-                index = collection->Length();
-            }
 
             collection->Set(context, index, details).Check();
             JSB_LOG(VeryVerbose, "script %s define property(export) %s",
@@ -403,19 +406,20 @@ namespace jsb
             Environment* environment = Environment::wrap(isolate);
             v8::Local<v8::Symbol> symbol = jsb_symbol(environment, ClassSignals);
             v8::Local<v8::Array> collection;
-            v8::Local<v8::Value> val_test;
             uint32_t index;
-            if (v8::MaybeLocal<v8::Value> maybe = target->Get(context, symbol); !maybe.ToLocal(&val_test) || val_test->IsUndefined())
+            if (target->HasOwnProperty(context, symbol).ToChecked())
             {
-                index = 0;
-                collection = v8::Array::New(isolate);
-                target->Set(context, symbol, collection).Check();
+                v8::Local<v8::Value> collection_val = target->Get(context, symbol).ToLocalChecked();
+                jsb_check(collection_val->IsArray());
+                collection = collection_val.As<v8::Array>();
+                index = collection->Length();
             }
             else
             {
-                jsb_check(val_test->IsArray());
-                collection = val_test.As<v8::Array>();
-                index = collection->Length();
+                index = 0;
+                collection = v8::Array::New(isolate);
+                jsb_quickjs_check(collection->IsArray());
+                target->Set(context, symbol, collection).Check();
             }
 
             collection->Set(context, index, signal).Check();
@@ -452,6 +456,7 @@ namespace jsb
 #else
             jsb_obj->Set(context, impl::Helper::new_string_ascii(isolate, "DEBUG_ENABLED"), v8::Boolean::New(isolate, false)).Check();
 #endif
+            jsb_obj->Set(context, impl::Helper::new_string_ascii(isolate, "CAMEL_CASE_BINDINGS_ENABLED"), v8::Boolean::New(isolate, internal::Settings::get_camel_case_bindings_enabled())).Check();
             jsb_obj->Set(context, impl::Helper::new_string_ascii(isolate, "version"), impl::Helper::new_string(isolate, JSB_STRINGIFY(JSB_MAJOR_VERSION) "." JSB_STRINGIFY(JSB_MINOR_VERSION) "." JSB_STRINGIFY(JSB_PATCH_VERSION))).Check();
             jsb_obj->Set(context, impl::Helper::new_string_ascii(isolate, "impl"), impl::Helper::new_string(isolate, JSB_IMPL_VERSION_STRING)).Check();
             jsb_obj->Set(context, impl::Helper::new_string_ascii(isolate, "callable"), JSB_NEW_FUNCTION(context, _new_callable, {})).Check();

bridge/jsb_class_info.cpp

@@ -180,7 +180,6 @@ namespace jsb
         // signals (@signal_)
         {
             v8::Local<v8::Value> val_test;
-            //TODO does prototype chain introduce unexpected behaviour if signal is decalred in super class?
             if (prototype->Get(p_context, jsb_symbol(environment, ClassSignals)).ToLocal(&val_test) && val_test->IsArray())
             {
                 v8::Local<v8::Array> collection = val_test.As<v8::Array>();
@@ -205,9 +204,7 @@ namespace jsb
         // detect all exported properties (which annotated with @export_)
         {
             v8::Local<v8::Value> val_test;
-            //TODO does prototype chain introduce unexpected behaviour if signal is decalred in super class?
             if (prototype->Get(p_context, jsb_symbol(environment, ClassProperties)).ToLocal(&val_test) && val_test->IsArray())
-            // if (prototype->Get(p_context, jsb_symbol(environment, ClassProperties)).ToLocal(&val_test) && val_test->IsArray())
             {
                 const v8::Local<v8::Array> collection = val_test.As<v8::Array>();
                 const uint32_t len = collection->Length();