Made changes in retry_test.go added a function named newRetryHTTP to … #2484
Conversation
Release/v1.44.2
Release/v1.45.0
Release/v1.46.0
Release/v1.46.1
Release/v1.46.2
Release/v1.46.3
…reduce redundancy
|
@Umang01-hash kindly review. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test code to reduce duplication by extracting common retry HTTP setup logic into a reusable helper function.
- Introduced a
newRetryHTTP()helper function to encapsulate the creation of retry HTTP instances - Updated 9 test functions to use the new helper instead of duplicating setup code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := retryConfig.AddOption(mockHTTP) | ||
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := retryConfig.AddOption(mockHTTP) | ||
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
pkg/gofr/service/retry_test.go
Outdated
| retryHTTP := retryConfig.AddOption(mockHTTP) | ||
| retryHTTP := newRetryHTTP() | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] There are two consecutive blank lines after the helper function call. This should be reduced to a single blank line for consistency with coding style.
|
@aaryyya Thanks for your contribution to GoFr! Your PR is currently failing the Code Quality test in the workflow with the below message. 
|
3 participants
No description provided.