updated default SQL histogram buckets for better latency analysis #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the default SQL query histogram configuration by introducing a wider range of bucket boundaries to improve real-world latency visibility.
Previously, the upper bound was limited to 10 ms, compressing slower queries into a single bucket.
Now, when no custom buckets are provided, a comprehensive default set (0.001 s to 60 s) is applied to capture micro to long-running query latencies effectively.
Key change:
Updated NewHistogram() in metrics.go to use a broader default bucket range.
Added validation for monotonically increasing bucket boundaries.
Benefits:
Improved accuracy for query latency analysis.
Better differentiation between fast, slow, and critical queries.
More meaningful P95/P99 latency metrics for production workloads.
Breaking Changes:
None
Existing code providing custom bucket values remains fully compatible.
Additional Information:
Changes are limited to metrics.go under the metrics package.