proposal: modular content filter (replication first)#283
Open
vtmocanu wants to merge 1 commit intogoharbor:mainfrom
Open
proposal: modular content filter (replication first)#283vtmocanu wants to merge 1 commit intogoharbor:mainfrom
vtmocanu wants to merge 1 commit intogoharbor:mainfrom
Conversation
Adds a proposal for a small content-filter package consumed by replication today, structured so future consumers (proxy cache, building on PR goharbor#280) can adopt it without re-inventing filter semantics. First user is per-platform selective replication (goharbor/harbor#19864). Don't-rewrite design: filtering preserves the original manifest list / OCI image-index digest. Cosign signatures and accessory linkages survive; the trade-off is that the destination index references children that may not be present (informative manifest unknown on pull, accepted per the user's explicit selection). Signed-off-by: Vlad Mocanu <vtmocanu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
proposals/new/modular_content_filter.mdproposing a small content-filter package consumed by Harbor replication today, with hooks to adopt it from proxy cache and other consumers later. First concrete user is per-platform selective replication (the long-standing request in goharbor/harbor#19864).Key design points:
manifest unknownon pull, accepted per the user's explicit selection).ByName,ByTag,ByLabel,ByType,ByPlatform), no composition (All/Any/Not), no speculative dimensions. Future predicates land additively when concrete consumers need them.Validation
No code in this PR; it's a proposal MD only. The proposal includes a Phase 1 verification checklist covering per-arch Cosign signature replication, GC and quota behaviour with dangling references at the destination, and idempotency, all to be exercised when the implementation lands.
Full disclosure
I don't have programming skills at the depth of a Harbor maintainer; I asked Claude Code to assist with researching the existing Harbor code and drafting this proposal.