fix linter issues #1325
Open
fix linter issues #1325
+13
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping @dhui |
dhui
reviewed
Nov 9, 2025
Member
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
@HaraldNordgren Thanks for the PR but we're unable to merge this as it's a breaking change.
database/util.go
Outdated
|
|
||
| // GenerateAdvisoryLockId inspired by rails migrations, see https://goo.gl/8o9bCT | ||
| func GenerateAdvisoryLockId(databaseName string, additionalNames ...string) (string, error) { // nolint: golint | ||
| // GenerateAdvisoryLockID inspired by rails migrations, see https://goo.gl/8o9bCT |
Member
There was a problem hiding this comment.
Unfortunately, this is a breaking change. e.g. there may be unknown dependent packages that use this function
Contributor
Author
|
@dhui Ah! Fair enough, I can scale back that change! |
HaraldNordgren
force-pushed
the
linter_issues
branch
3 times, most recently
from
3b0d424 to
6ea7216
Compare
Contributor
Author
|
@dhui Updated! Can you take another look? |
HaraldNordgren
force-pushed
the
linter_issues
branch
from
6ea7216 to
1ee8337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.