-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x86: allow decoding of AVX instructions #10
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: fa2736f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
Message from Michal Hruby: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
This PR (HEAD: 1209840) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036. Important tips:
|
This PR (HEAD: 4a7d831) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036. Important tips:
|
Message from Cherry Mui: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
Message from Michal Hruby: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
This PR (HEAD: b173903) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036. Important tips:
|
Message from Michal Hruby: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
Message from Cherry Mui: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
Message from Michal Hruby: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. |
Fixes golang/go#48584 golang/go#41043 golang/go#69792
This PR extends the decoder in x86asm to deal with VEX-encoded instructions, the way I went about this was to extend the table built by x86map - this ultimately required updating the
x86.csv
- I combined it with thex86.v0.2.csv
and took the VEX definitions from there, as they included the[xy]mmV
references that were necessary to decode all the registers.Now I have to admit that I know quite little about x86 instructions, so it's very possible I missed quite a lot of stuff, but combining the new code with how it was dealing with REX instructions went pretty well and as far as the tests can say, this is now able to decode VEX-prefixed instructions.
Any feedback would be appreciated.