Skip to content

Commit

Permalink
main.star: run vscode-go presubmit against all go versions
Browse files Browse the repository at this point in the history
Right now, only gotip presubmit is triggered in vscode-go presubmit.

For golang/vscode-go#3533

Change-Id: I91baea2d3fd978f3c46eeeb972279fc8b6af0bd4
Reviewed-on: https://go-review.googlesource.com/c/build/+/645355
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Hongxiang Jiang <[email protected]>
  • Loading branch information
h9jiang authored and gopherbot committed Jan 29, 2025
1 parent 0f04c5b commit 7cf65fd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 0 additions & 3 deletions generated/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -58736,17 +58736,14 @@ config_groups {
tryjob {
builders {
name: "golang/try/x_vscode-go-go1.22-linux-amd64_docker"
includable_only: true
disable_reuse: true
}
builders {
name: "golang/try/x_vscode-go-go1.23-linux-amd64_docker"
includable_only: true
disable_reuse: true
}
builders {
name: "golang/try/x_vscode-go-go1.24-linux-amd64_docker"
includable_only: true
disable_reuse: true
}
builders {
Expand Down
8 changes: 6 additions & 2 deletions main.star
Original file line number Diff line number Diff line change
Expand Up @@ -2144,8 +2144,12 @@ def _define_go_ci():
# Make presubmit mandatory for builders deemed "fast".
# See go.dev/issue/17626.
if project != "go" and go_branch_short != "gotip":
x_repo_presubmit = builder_type in ["linux-amd64", "linux-386", "darwin-amd64_14", "windows-amd64"] and \
enabled(LOW_CAPACITY_HOSTS, project, go_branch_short, builder_type, KNOWN_ISSUE_BUILDER_TYPES)[2]
first_class_subset = builder_type in ["linux-amd64", "linux-386", "darwin-amd64_14", "windows-amd64"]
vscode_go_special_case = project == "vscode-go" and builder_type == "linux-amd64_docker"

in_postsubmit = enabled(LOW_CAPACITY_HOSTS, project, go_branch_short, builder_type, KNOWN_ISSUE_BUILDER_TYPES)[2]

x_repo_presubmit = in_postsubmit and (first_class_subset or vscode_go_special_case)
luci.cq_tryjob_verifier(
builder = name,
cq_group = go_cq_group(project, "gotip").name,
Expand Down

0 comments on commit 7cf65fd

Please sign in to comment.