-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mmap: implement io.WriterTo and io.ReadSeeker #70
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: ab75851) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/exp/+/555796. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/555796. |
Preliminary results from the included benchmark, which represents simple usage via io.Copy:
|
Message from Leo Antunes: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/555796. |
Message from qiulaidongfeng: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/555796. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/555796. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/555796. |
Message from qiulaidongfeng: Patch Set 2: -Run-TryBot Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/555796. |
ab75851
to
a3eda1e
Compare
This PR (HEAD: a3eda1e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/exp/+/555796. Important tips:
|
This extends the ReaderAt type to also implement io.WriterTo and
io.ReadSeeker, the later being required for the former.
Fixes golang/go#56422