expvar: add Delete function#73815
Conversation
|
This PR (HEAD: 7faabc8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/675116. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 1: Commit-Queue+1 Copied votes on follow-up patch sets have been updated:
(1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-05-21T18:44:12Z","revision":"aff4e27d37d7ad66bac69f9035f2e107ae92ff35"} Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_debiansid has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
Adds a `Delete` function to the expvar package to remove a named exported variable. Calls `Map.Delete`. Fixes golang#73814
7faabc8 to
e911d7e
Compare
|
This PR (HEAD: e911d7e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/675116. Important tips:
|
|
Message from Mohamed Hamza: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Mohamed Hamza: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
This PR (HEAD: e025f1c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/675116. Important tips:
|
|
Message from Mohamed Hamza: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 5: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-05-21T23:07:09Z","revision":"796dcb8dcf562d3e2f2b1aaa5fe227cafe56b4bf"} Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from David Chase: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Mohamed Hamza: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Mohamed Hamza: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 5: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Mohamed Hamza: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Keith Randall: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
|
Message from Mohamed Hamza: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/675116. |
Adds a "Delete" function to the expvar package to remove a named exported
variable. Calls "Map.Delete".
Fixes #73814