http2: send client conn flow control bytes back immediately #144
+20
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/2 server must return client connection flow control bytes back immediately on receiving data frame. Connection flow control updates must not depend on whether data has been read by application handler or not. This prevents fast streams from starving due to slow streams.
|
This PR (HEAD: 892fc35) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/421975 to see it. Tip: You can toggle comments from me using the |
|
Message from Damien Neil: Patch Set 1: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421975. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 server must send client connection flow control bytes
back immediately on receiving the data frame. Connection flow control
updates must not depend on whether data has been read by the
application handler or not. This prevents fast streams from starving
due to slow streams.
Fixes: golang/go#54330