-
Notifications
You must be signed in to change notification settings - Fork 126
rate: fix limiter becoming invalid under high rate and concurrency #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
3826bf4 to
9e89fd9
Compare
|
This PR (HEAD: 9e89fd9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/714520. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
This PR (HEAD: 240d18d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/714520. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from 恩尧张: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from 恩尧张: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from t hepudds: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
This PR (HEAD: 1484d28) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/714520. Important tips:
|
|
Message from t hepudds: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from t hepudds: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from t hepudds: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
This PR (HEAD: 8ef2560) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/714520. Important tips:
|
The rate limiter could become ineffective when the request rate or concurrency were high. This is because we allowed time reverse jump. This change modifies the the time calculation of the limiter. If input an old time, we don't change time of limiter. Fixes golang/go#65508
|
This PR (HEAD: 936078a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/714520. Important tips:
|
|
Message from 恩尧张: Patch Set 6: Code-Review+1 (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from t hepudds: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-11-03T03:49:23Z","revision":"8c24c6684144bf247a7c65e8d3d58e3e303c9b80"} Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from t hepudds: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
|
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/714520. |
The rate limiter could become ineffective when the request rate or concurrency were high.
This is because we allowed time reverse jump.
This change modifies the the time calculation of the limiter.
If input an old time, we don't change time of limiter.
Fixes golang/go#65508