gopls: group comments for hover #563
Open
+253
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the compiler source, i noticed that the
hover results of cmd/compile/internal/ir.Op are pretty bad.
First of all currently the preference order is like this:
spec.Doc, decl.Doc, spec.Comment. I don't understand why
we prefer decl.Doc over spec.Comment, but at the same time
i also wonder why we do not show both spec.Comment and
spec.Doc in the hover result.
But getting to the point: While looking at the ir.Op
i noticed that we do not really have a way to detect
group comments (comments that reference few constants),
some Doc comments of ir.Op are group comments, some others
are not.
This change tries to address that, by introducing of a
concept of a group comment, see examples in the added test
to get an idea how it works.