-
Notifications
You must be signed in to change notification settings - Fork 2.3k
gopls/internal/cache: set GO111MODULE=on for go.work view #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
GO111MODULE=auto disables modules when go tool sees only go.work file. $ go version go version go1.23.1 linux/amd64 $ echo 'go 1.24' > go.work $ go version go version go1.24.0 linux/amd64 $ GO111MODULE=auto go version go version go1.23.1 linux/amd64 When go in $PATH is too old this breaks gopls for repositories like this: https://github.com/containers/container-libs/ Signed-off-by: Konstantin Khlebnikov <[email protected]>
|
Original issues looks like this |
|
This PR (HEAD: 30741a5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/724262. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/724262. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/724262. |
GO111MODULE=auto disables modules when go tool sees only go.work file.
$ go version
go version go1.23.1 linux/amd64
$ echo 'go 1.24' > go.work
$ go version
go version go1.24.0 linux/amd64
$ GO111MODULE=auto go version
go version go1.23.1 linux/amd64
When go in $PATH is too old this breaks gopls for repositories like this:
https://github.com/containers/container-libs/