Skip to content

package.json: clarify format and precedence of env-setting debug attributes #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

polinasok
Copy link
Contributor

@polinasok polinasok commented Apr 23, 2022

Updates #2206

@gopherbot
Copy link
Collaborator

This PR (HEAD: 866e950) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/401974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/c5082b31-1d00-4184-a5b6-fc480d7c17f6


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/c5082b31-1d00-4184-a5b6-fc480d7c17f6


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 4a6466c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/401974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/fd3f3f46-0edf-42d8-9b41-89edecf3144f


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 4: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/fd3f3f46-0edf-42d8-9b41-89edecf3144f


Please don’t reply on this GitHub thread. Visit golang.org/cl/401974.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 25, 2022
…ibutes

Updates #2206

Change-Id: Ifd31119b0eafae6ea617ed5c7d405626e3720345
GitHub-Last-Rev: 4a6466c
GitHub-Pull-Request: #2209
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401974
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Polina Sokolova <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/401974 has been merged.

@gopherbot gopherbot closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants