-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snippets: remove the comma from the placeholder in forr
#3602
base: master
Are you sure you want to change the base?
Conversation
When using `forr` snippet, the comma in the `_, ` placeholder will be deleted if user edit the placeholder. So the comma should not be part of the placeholder
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 738c0bf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/627895. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/627895. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/627895. |
Message from my x: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/627895. |
When using "forr" snippet,
the comma in the "_, " placeholder will be deleted
if user edit the placeholder.
So the comma should not be part of the placeholder