Module improvements - #113
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves GOL-57
Resolves GOL-393
This PR completes the same-process module-loader work.
What this enables
node_moduleswith Node-style package entry points,exports/importsmaps, conditions, self-references, extensions, directories, and symlinks.require(esm), CJS named exports/reexports, JSON import attributes, cycles, and Node-compatible cache behavior.require.cache,require.extensions,Module._pathCache, custom extension handlers, and side-effect-freerequire.resolve.Accepted follow-up boundaries are limited to:
process.execPath, and spawned-process loader modes;.node, WebAssembly/V8-specific behavior, and other true WASI/platform gaps;Ordinary same-process package resolution, module-kind detection, registered-loader behavior, and CommonJS/ESM interop are covered here and are not deferred.
Node compatibility
runnable + known-gap): 4,295 → 4,425 (+130); known gaps 1,210 → 1,191 (−19); passing coverage 71.8% → 73.1%.Functional followups
node:vmrealm, GC, leak, and cached-data behavior.Modulehooks.require(esm).unhandledRejectionturn ordering.Performance / CI related followups
package.jsonlookups.require(esm)graph analysis.string_decoderhang.