-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows MSVC Compilation #88
base: main
Are you sure you want to change the base?
Conversation
MSVC doesn't seem to like this way of instantiating test suites...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you paste the error message you get before this PR in the PR comment thread?
@@ -94,6 +94,7 @@ TEST_P(NormTest, Hessian) { | |||
} | |||
} | |||
|
|||
#ifndef _MSC_VER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a comment as to why this is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting the same issue @saran-t was getting here: #21
It was inscrutable to me, but I bisected commenting out regions of the file until I came to INSTANTIATE_TEST_SUITE_P
, which is apparently only ever used in NormTest.cc
.
I guess the Google Testing System has trouble with MSVC? Perhaps it's fixed in an updated version. 🤷♂️
Nope, MSVC still dies on
|
Clang and Ninja can be a bit squirrely to work with on Windows, but commenting out this section in
norm_test.cc
allows the rest of the system to compile and run great with MSVC!EDIT: Also, you folks might appreciate this little hobby project I've been working on on the side:
https://github.com/zalo/mujoco_wasm
https://zalo.github.io/mujoco_wasm