Add pre-commit verification to CI#1072
Closed
maichmueller wants to merge 1 commit intogoogle-deepmind:masterfrom
Closed
Add pre-commit verification to CI#1072maichmueller wants to merge 1 commit intogoogle-deepmind:masterfrom
maichmueller wants to merge 1 commit intogoogle-deepmind:masterfrom
Conversation
Collaborator
|
Hi @maichmueller, I think this is great, and in another world where I had enough time to properly look into it and understand how it all works, I would fully embrace the move. I realize it would probably save us time long term but I don't even have the time to spend on the initial cost of learning how it all works. I also think this is a bit heavy for contributors and would rather keep doing what we have been and keep it easy to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1071.
Adds a CI step that verifies all pre-commit checks pass, otherwise fails the build step and exits. Not built on #1071 yet to keep diff small and the changes easily in sight. Will need #1071 merged into it to become operational.
Currently set as a condition for the build job to run, but can be set as a side job.
Merging this PR will mean that the entire codebase needs to apply the checks and formatting mandated by the pre-commit setup and as such requires one behemoth PR to apply these changes, otherwise all CI steps will constantly fail.
I do not recommend merging this until all open PRs in consideration for the project have been merged or closed so that the entire repo can see all of the pre-commit hooks applied to it.