Add Shogi implementation to OpenSpiel#1510
Add Shogi implementation to OpenSpiel#1510Arahan-kujur wants to merge 1 commit intogoogle-deepmind:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This was done in #1509 by the person who originally submitted the comment. |
How would you prefer to proceed in this case? I'm happy to update my implementation, collaborate with the other contributor, or adapt it however fits best with the project. |
|
Thanks for the implementation. In cases like this, I think the best thing to do is take the first implementation, especially when it's being contributed by the same person and directly in conjunction with the issue that was posted. But this is happening a lot these days, so I will put something up in the contributor guidelines -- and maybe pin an issue -- to ensure that we don't waste time duplicating work. For future contributions (not just to OpenSpiel), please do take a look at the Pull Requests and maybe ask by posting an issue first, before you do any work. If you're still interested in contributing a sizeable controbution to OpenSpiel, please either respond to an existing issue or opening an issue to discuss it first. |
|
Given the frequency of the PR duplication over the past few months, I've added the following issue: I've pinned it to the Issues page so hopefully that helps with awareness. Sorry for the time you spent working on this. There are other games we would be interested in if you're still interested.. take a look at #843 . |
This PR adds an implementation of the Shogi board game to OpenSpiel.
Features:
Includes unit tests for:
Known limitations: