fix the owning issues of infostate tree#1514
Open
maichmueller wants to merge 1 commit intogoogle-deepmind:masterfrom
Open
fix the owning issues of infostate tree#1514maichmueller wants to merge 1 commit intogoogle-deepmind:masterfrom
maichmueller wants to merge 1 commit intogoogle-deepmind:masterfrom
Conversation
the aliasing shared ptr was a clever idea but pybind11 considers shared ptrs to be copyable in terms of its content apparently. This prevents holding an infostate node in a shared ptr, since it contains unique ptr members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aliasing shared ptr for infostate node types was a clever idea, but pybind11 considers every shared ptrs to own a copyable type apparently. This prevents holding an infostate node in a shared ptr, since it contains unique ptr members.
No clue why this did not come up in ci tests or in my local setup prior. I was using apple-clang 17 and the repo's installed pybind11 and could not reproduce the error.
Anyway, this fix should avoid the holder issue #1502