fix: clamp topic_entropy to prevent negative values and add pytest suite#4
Merged
Merged
Conversation
Contributor
Author
|
is there any updates? |
Member
|
@Karan24Soni Thank you for the fix! |
Contributor
Author
|
@huangyz0918 Thanks for the review and approval! Just checking whether there is anything else needed from my side before this PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed a bug in topic_entropy where single-class distributions were returning a tiny negative number (like -1.44e-12) because of that 1e-12 smoothing. just clamped it to 0 so it stops acting weird.
also added a tests/ folder at the repo root since pyproject.toml already had testpaths = ["tests"] but there were zero tests. wrote 25 pytest tests covering topic_entropy, embedding_coverage, overall_diversity, failure_rate, and compute_samples_to_threshold from proeval/utils/metrics.py — all pure functions so no API keys or GPU needed to run em.