A small improvement on the readability of the code. #17
Conversation
| override fun getItemCount(): Int { | ||
| return list.size | ||
| } | ||
| override fun getItemCount(): Int = list.size |
There was a problem hiding this comment.
I think it's possible to improve even more, what do you think about that?
| override fun getItemCount(): Int = list.size | |
| override fun getItemCount() = list.size |
There was a problem hiding this comment.
Pierre I think the way it as originally was better for initial understanding. Then as you rightly pointed out the condensed refactored version is how you would solve on the job. The original in my opinion helps with basic beginner understanding ie. It highlights getItemCount is a function with return type Int and the return FROM that function is the list size. With out knowing this, its possible to interpret the condensed version as a variable assignment. Then what getItemCount does with it? and why not as a parameter to the variable etc. So a whole rabbit hole of questions which pop up during the learning journey.
3 participants
No description provided.