Skip to content

Update Entity_extraction_JSON notebook to use genai module #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Mar 5, 2025

Refers #446

  • Updated module google-generativeai to use google-genai>=1.0.0
  • Refactored imports
  • Docs update was not required IMO

Following PRs completes the refactor and update of examples/json-capabilities/*:

Also, I'm following the instructions in the above-referenced issue to follow 1 notebook max per PR, but I think there are some small notebooks like the above four that could have been a single PR since they are related a bit and are not that complex/lengthy. Also have gained experience in updating notebooks :)
So would like to make a single PR(ofc if it makes sense) from now on if allowed by maintainers. thanks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Mar 5, 2025
Copy link
Collaborator

@Giom-V Giom-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Faakhir30!

@Giom-V
Copy link
Collaborator

Giom-V commented Mar 5, 2025

Also, I'm following the instructions in the above-referenced issue to follow 1 notebook max per PR, but I think there are some small notebooks like the above four that could have been a single PR since they are related a bit and are not that complex/lengthy. Also have gained experience in updating notebooks :) So would like to make a single PR(ofc if it makes sense) from now on if allowed by maintainers. thanks

@Faakhir30 I think it's better for everyone's visibility to keep one PR per notebook so that it limits the chances that two contributors work on the same thing. That said, if you are clear in the RP name, you can mix multiple notebooks in one.

@Giom-V Giom-V merged commit 208d5d7 into google-gemini:main Mar 5, 2025
6 checks passed
@Faakhir30 Faakhir30 deleted the genai_entity_extraction_json branch March 5, 2025 12:46
freddyaboulton pushed a commit to freddyaboulton/gemini-cookbook that referenced this pull request Mar 5, 2025
…mini#509)

Refers google-gemini#446

* Updated module google-generativeai to use google-genai>=1.0.0
* Refactored imports

Signed-off-by: Faakhir30 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants