Skip to content

Chat_with_SQL_using_langchain.ipynb update to google genai#646

Merged
Giom-V merged 5 commits intogoogle-gemini:mainfrom
omkenge:chatsql
Apr 7, 2025
Merged

Chat_with_SQL_using_langchain.ipynb update to google genai#646
Giom-V merged 5 commits intogoogle-gemini:mainfrom
omkenge:chatsql

Conversation

@omkenge
Copy link
Copy Markdown
Contributor

@omkenge omkenge commented Apr 3, 2025

No description provided.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions Bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Apr 3, 2025
…olab metadata and clean up output formatting
@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 3, 2025

Thanks for the submission @omkenge. I made some minor comments for readability but nothing critical.

@omkenge
Copy link
Copy Markdown
Contributor Author

omkenge commented Apr 3, 2025

@Giom-V Somehow I can not see your comments :)

@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 3, 2025

@Giom-V Somehow I can not see your comments :)

Damn, maybe I closed reviewNB too fast :(

Comment thread examples/langchain/Chat_with_SQL_using_langchain.ipynb
Comment thread examples/langchain/Chat_with_SQL_using_langchain.ipynb
@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 3, 2025

@Giom-V Somehow I can not see your comments :)

I redid the review. It wasn't much so it was quick :)

@Giom-V Giom-V self-assigned this Apr 3, 2025
@omkenge
Copy link
Copy Markdown
Contributor Author

omkenge commented Apr 3, 2025

@Giom-V Thanks For the Review :) And also Thank you for help

@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 4, 2025

Thanks @omkenge! Can you just run the formatting script so I can proceed with the merge?

…olab metadata and improve output formatting
@omkenge
Copy link
Copy Markdown
Contributor Author

omkenge commented Apr 5, 2025

@Giom-V Thank You for Review :)

@Giom-V Giom-V merged commit af4fd22 into google-gemini:main Apr 7, 2025
3 of 5 checks passed
@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 7, 2025

Thank you @omkenge !

Giom-V pushed a commit to Giom-V/gemini-api-cookbook that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants