LowercaseTextProcessor for text normalization#11
Open
suparshwa31 wants to merge 1 commit intogoogle-gemini:mainfrom
Open
LowercaseTextProcessor for text normalization#11suparshwa31 wants to merge 1 commit intogoogle-gemini:mainfrom
suparshwa31 wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
the PR issue has been resolved
|
hey @suparshwa31 looks like you have already raised the PR for my issue #11 but i would like to have the maintainers check this and see if it's at all valid for this library. Let's have a proper discussion and let's not write AI slop code for the sake of contribution :)) |
|
Please keep in mind that the maintainers spend valuable time on every PR and issue, so let’s make the most of everyone’s time 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
LowercaseTextProcessorto thegenai_processors/contribmodule. It converts incoming text parts to lowercase while preserving non-text parts and all metadata.Changes Introduced
lowercase_text_processor.pyundergenai_processors/contribLowercaseTextProcessorinheriting fromPartProcessorlowercase_text_processor_test.pyundergene_processors/tests