Add LanguageDetectProcessor for automatic language detection#34
Conversation
- Changed condition from `part.text` to `part.text is not None` - Ensures empty strings are processed and marked as "unknown" language - All tests now passing (8/8)
Summary of ChangesHello @Solventerritory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a LanguageDetectProcessor for automatic language detection, which is a great addition to the contrib module. The implementation is solid and comes with a comprehensive test suite. My review includes a few suggestions to better align the new processor with the existing framework, mainly by inheriting from the base Processor class and correcting an import path. I've also pointed out a minor improvement in exception handling. These changes will improve maintainability and ensure seamless integration.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description Closes #14
This PR adds a new
LanguageDetectProcessorto the contrib module that automatically detects the language of text parts and adds the detected language code to the part's metadata.Changes
genai_processors/contrib/language_detect_processor.pywith theLanguageDetectProcessorclasstests/contrib/test_language_detect_processor.py(8 tests)genai_processors/contrib/__init__.pyto export the new processorpyproject.tomlto includelangdetect>=1.0.9dependencyFeatures
langdetectlibraryTesting
All 8 tests passing:
Usage Example