Fix python-tests workflow: split get_sample_dirs into its own job#1420
Open
salmanmkc wants to merge 1 commit intogoogle:mainfrom
Open
Fix python-tests workflow: split get_sample_dirs into its own job#1420salmanmkc wants to merge 1 commit intogoogle:mainfrom
salmanmkc wants to merge 1 commit intogoogle:mainfrom
Conversation
The build job declares `needs: get_sample_dirs`, but get_sample_dirs was defined as a step inside build rather than as a separate job. This caused GitHub Actions to reject the workflow with: The workflow must contain at least one job with no dependencies. This commit: - Extracts get_sample_dirs into its own job with proper outputs - Replaces undefined $PYTHON_DIR with the actual path (samples/python) - Formats the find output as JSON array for fromJson() compatibility - Adds an if condition to skip the build matrix when no samples exist Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
buildjob declaresneeds: get_sample_dirs, butget_sample_dirswas defined as a step insidebuildrather than as a separate job. This causes GitHub Actions to reject the workflow with:Changes
get_sample_dirsinto its own job with properoutputs$PYTHON_DIRwith the actual path (samples/python)findoutput as a JSON array forfromJson()compatibilityifcondition to skip the build matrix when no sample directories exist