Google Firestore: implement agent demonstrating session persistence using Firestor for Java ADK#1563
Open
mohan-ganesh wants to merge 1 commit intogoogle:mainfrom
Open
Google Firestore: implement agent demonstrating session persistence using Firestor for Java ADK#1563mohan-ganesh wants to merge 1 commit intogoogle:mainfrom
mohan-ganesh wants to merge 1 commit intogoogle:mainfrom
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mohan-ganesh
force-pushed
the
firestore-session
branch
2 times, most recently
from
4628856 to
2271995
Compare
…sing Firestore database for java adk
mohan-ganesh
force-pushed
the
firestore-session
branch
from
2271995 to
af8f631
Compare
koverholt
requested changes
Apr 6, 2026
Collaborator
koverholt
left a comment
koverholt
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I see that this is based on a pending PR in adk-java (google/adk-java#1096), so we will need to wait for that PR to get reviewed and/or merged/released before we can review and suggest edits on this docs update. I'll mark this as blocked until that happens.
Once that happens, there are a number of issues that need to be addressed in this PR for consistency and formatting, but these can wait until the upstream PR in adk-java is reviewed:
- Use a icon/logo instead of a diagram for catalog icon
- Fix versions throughout and update version tag with corresponding Java version
FirestoreDatabaseRunnerrequiresgcs.adk.bucket.nameto be configured, which is not mentioned- Fill in the Configuration section with actual property names and examples
- Fix the
forecastkey ingetCurrentTime, should betimeor similar - Follow the established integration page structure per Contributing Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an additional for "Integration"
This commit includes an example and details of Using the Google Cloud Firestore for Session management