-
Notifications
You must be signed in to change notification settings - Fork 351
Add TS examples for function tools and agent as a tool #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to put these two examples in separate subdirectories? Also, should not we include a tsconfig.json
and a package.json
for them to make sure the users can quickly run them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should create a subdirectory for each feature md file i.e function-tools.md and then within this subdirectory, just the ts files for each example. Because I checked the path structure for function-tools in adk-docs/examples/python/snippets - tools is a directory. function-tools is the subdirectory. No need to create one more layer of subdirectories for each example ts files, does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yes we agree we will add a tsconfig.json and a package.json for each feature so each sample code is self-contained.
// Define the summarization agent that will be used as a tool | ||
const summaryAgent = new LlmAgent({ | ||
name: 'summary_agent', | ||
model: 'gemini-2.5-flash', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we stay consistent with python and use 'gemini-2.0-flash'? I can go either way on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use 2.5 model because python library and code examples were created a while ago.
issue # 440671611