Skip to content

Conversation

slothwriter
Copy link
Collaborator

issue # 440671611

@slothwriter slothwriter marked this pull request as ready for review September 9, 2025 18:37
@tpryan tpryan added the adk-js label Sep 10, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to put these two examples in separate subdirectories? Also, should not we include a tsconfig.json and a package.json for them to make sure the users can quickly run them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a subdirectory for each feature md file i.e function-tools.md and then within this subdirectory, just the ts files for each example. Because I checked the path structure for function-tools in adk-docs/examples/python/snippets - tools is a directory. function-tools is the subdirectory. No need to create one more layer of subdirectories for each example ts files, does it make sense?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes we agree we will add a tsconfig.json and a package.json for each feature so each sample code is self-contained.

// Define the summarization agent that will be used as a tool
const summaryAgent = new LlmAgent({
name: 'summary_agent',
model: 'gemini-2.5-flash',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we stay consistent with python and use 'gemini-2.0-flash'? I can go either way on this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use 2.5 model because python library and code examples were created a while ago.

@slothwriter slothwriter requested a review from tpryan September 16, 2025 13:22
@slothwriter slothwriter deleted the ts-docs branch September 16, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants